[PATCH] D62739: AMDGPU: Always emit amdgpu-flat-work-group-size
Yaxun Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri May 31 14:01:23 PDT 2019
yaxunl added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:7885
+ // By default, restrict the maximum size to 256.
+ F->addFnAttr("amdgpu-flat-work-group-size", "128,256");
> b-sumner wrote:
> > Theoretically, shouldn't the minimum be 1?
> That's what I thought, but the backend is defaulting to 2 * wave size now
I don't get it. This attribute indicates the possible workgroup size range this kernel may be run with, right? It only depends on how user execute the kernel. How is it related to backend defaults?
CHANGES SINCE LAST ACTION
More information about the cfe-commits