[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends
Melanie Blower via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri May 31 10:28:20 PDT 2019
mibintc added a comment.
In D53157#1525311 <https://reviews.llvm.org/D53157#1525311>, @kpn wrote:
> Oh, this ticket is not going to die from neglect. It is true that D43515 <https://reviews.llvm.org/D43515> is a higher priority, but I need this IRBuilder work done as well. My department head wanted it done by the end of _last_ year. It's not going to die.
> How about I merge your changes into this ticket and we continue work over here? There is the issue of the documentation that lebedev.ri asked you to write. Can I talk you into putting that together and sending it to me <kevin.neal at sas.com>? I'll work on the documentation that I was asked to write. Between the two of us we should be in pretty good shape. Does that work for you?
Yes I'll do that. Thanks.
> I am still waiting for feedback from an actual consumer of the IRBuilder who will be using this new functionality. If someone clang-side could chime in on this ticket I'd very much appreciate it.
I wrote a clang patch that works with your IRBuilder modifications. I also checked with the Intel fortran team and they think this interface will be workable for them too. From Intel perspective it's +1.
CHANGES SINCE LAST ACTION
More information about the cfe-commits