[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

Balázs Kéri via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 30 03:37:18 PDT 2019


balazske added a comment.

It looks like that the same test can be applied as in D60463 <https://reviews.llvm.org/D60463> but check only the first line of the AST dump. The first line contains information about the actual Decl only. This checks less than checking the full AST dump but finds some of wrong `SourceLocation` import. The problem is that the test can not be added yet because there are other failures. At least one new patch is needed with corrections related to import of `TypeSourceInfo`. Anyway this change (and the others) can not be added together with the test because multiple patches (including this) are needed to make the test not fail.

Source locations can be observed here:
http://ce.steveire.com/z/WB9VAu


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60499/new/

https://reviews.llvm.org/D60499





More information about the cfe-commits mailing list