[PATCH] D62580: [OpenCL] Use long instead of long long in x86 builtins
Erich Keane via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed May 29 08:44:04 PDT 2019
erichkeane added a comment.
'O' is an interesting choice. Any real justification for it, or just "what was available"? It definitely needs to be documented in the top of Builtins.def however.
Comment at: clang/lib/AST/ASTContext.cpp:9362
+ case 'O':
+ assert(!IsSpecial && "Can't use two 'N', 'W', 'Z' or 'O' modifiers!");
+ assert(HowLong == 0 && "Can't use both 'L' and 'O' modifiers!");
Likely need to update the asserts in the other places this is used, such as 'Z'.
Also, add the 'O' to the documentation in Builtins.def
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits