[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.
Stephane Moore via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue May 28 19:32:13 PDT 2019
stephanemoore reopened this revision.
stephanemoore added inline comments.
This revision is now accepted and ready to land.
Comment at: test/clang-tidy/google-objc-global-variable-declaration.m:48
static NSString* gMyIntGood = 0;
+extern NSString* Y2Good;
Whoops, we forgot the warning that should be generated for this case 😅
I had to rollback the commit. Can you update the patch to resolve the test failure(s)?
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
More information about the cfe-commits