[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.
Eric Fiselier via cfe-commits
cfe-commits at lists.llvm.org
Tue May 28 01:33:04 PDT 2019
* The alignment check can be removed, and I'll do so tomorrow if someone
doesn't beat me to it.
On Tue, May 28, 2019 at 1:54 AM Eric Fiselier <eric at efcs.ca> wrote:
> The alignment check can just be removed.
> On Mon., May 27, 2019, 7:57 p.m. Ulrich Weigand via Phabricator, <
> reviews at reviews.llvm.org> wrote:
>> uweigand added a comment.
>> Looks like this test is failing on SystemZ since it was added, making all
>> our build bots red:
>> error: CHECK: expected string not found in input
>> // CHECK: @[[EMPTY_STR:.+]] = private unnamed_addr constant [1 x i8]
>> zeroinitializer, align 1
>> note: scanning from here
>> ; ModuleID =
>> note: possible intended match here
>> @.str = private unnamed_addr constant [1 x i8] zeroinitializer, align 2
>> The problem is that string constants are 2-aligned according to the
>> SystemZ ABI (this is a bit different, but deliberate in order to allow
>> computing their addresses with a LARL instruction). This makes all the
>> "align 1" checks fail.
>> Is this test deliberately verifying the alignment, or could this just be
>> rC Clang
>> CHANGES SINCE LAST ACTION
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits