[PATCH] D62363: [X86] Enable intrinsics that convert float and bf16 data to each other
Craig Topper via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon May 27 20:40:28 PDT 2019
craig.topper added inline comments.
Comment at: lib/Headers/avx512bf16intrin.h:37
+/// This intrinsic corresponds to the <c> EmitX86CvtBF16ToFloatExpr </c>
> craig.topper wrote:
> > This needs to be a comment that's useful to user's of the compiler not compiler developers. It can't reference an implementation function inside the compiler
> i can not think out a comment that 's needed by users since other comments has explained this function clearly, can i just remove this comment?
Just write "This intrinsic does not correspond to a specific instruction,"
CHANGES SINCE LAST ACTION
More information about the cfe-commits