[PATCH] D62298: [CodeComplete] Filter override completions by function name

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 24 02:17:08 PDT 2019


ilya-biryukov added a comment.

In D62298#1515399 <https://reviews.llvm.org/D62298#1515399>, @kadircet wrote:

> LGTM
>
> Have one question though, does it improve behavior in vscode? Since label seems to be the same, it will most definitely improve clangd's ranking but vscode ignores it anyway.


It does, VSCode relies on `filterText` for ranking and since it now starts with the function name the ranking is much better.

Will fix the rest of the comments and land this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62298/new/

https://reviews.llvm.org/D62298





More information about the cfe-commits mailing list