[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

Tom Rix via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 20 17:45:31 PDT 2019


trixirt added a comment.

Latest change addresses most of issues.
Outstanding is adding a test when garbage GuardStyle value is fed into config.
The trial testcase used only CHECK-*-NOT which caused complaining from test harness looking for the CHECK- cases.
Looking for something similar in the other checker tests did not turn up anything.
In general it seems like clang-tidy assumes developers get the string names of the options and their values correct and does not provide a lot of (any?)  checking.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61508/new/

https://reviews.llvm.org/D61508





More information about the cfe-commits mailing list