[PATCH] D62143: [clangd] Make it possible to use VFS from parsing for getting tidy options

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 20 09:37:46 PDT 2019


sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

This seems fine:

- please give this `function<>` type a name - maybe `ClangTidyOptionsBuilder` or so?
- while we're defining this, we should make it threadsafe because that's what we really want
- document that it's threadsafe and approximately why we don't use ClangTidyOptionsProvider


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62143/new/

https://reviews.llvm.org/D62143





More information about the cfe-commits mailing list