[PATCH] D61841: [clangd] Respect WarningsAsErrors configuration for clang-tidy

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 14 21:28:31 PDT 2019


nridge added inline comments.


================
Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:346
+      std::string CheckName = CTContext->getCheckName(Info.getID());
+      if (!CheckName.empty() && WarningAsErrorFilter->contains(CheckName)) {
+        Level = DiagnosticsEngine::Error;
----------------
ilya-biryukov wrote:
> Why can't we call `CTContext->treatAsError()` here?
Good point, that makes this much easier. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61841/new/

https://reviews.llvm.org/D61841





More information about the cfe-commits mailing list