[PATCH] D61364: [libcxx] [test] Fix incorrect allocator::construct assertions in associative container tests

Billy Robert O'Neal III via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 14 15:58:58 PDT 2019


BillyONeal marked an inline comment as done.
BillyONeal added inline comments.


================
Comment at: test/std/containers/map_allocator_requirement_test_templates.h:236
     const ValueTp v(42, 1);
-    cc->expect<const ValueTp&>();
+    cc->expect<const ValueTp&&>();
     It ret = c.insert(c.end(), std::move(v));
----------------
EricWF wrote:
> I really think the current behavior libc++ has here is correct.
> 
> 
File a DR to retroactively make libc++'s behavior standard then? :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61364/new/

https://reviews.llvm.org/D61364





More information about the cfe-commits mailing list