[PATCH] D61814: [CFG] NFC: Remove implicit conversion from CFGTerminator to Stmt *, make it a variant class instead.

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 14 13:39:32 PDT 2019


Szelethus accepted this revision.
Szelethus added a comment.

LGTM!



================
Comment at: clang/include/clang/Analysis/CFG.h:514
+  CFGTerminator() { assert(!isValid()); }
+  CFGTerminator(Stmt *S, Kind K = StmtBranch) : Data(S, K) {}
 
----------------
Can we add something to check that the integer part of `Data` is actually large enough to store an object of type `Kind`, even if we add more values to the enum?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61814/new/

https://reviews.llvm.org/D61814





More information about the cfe-commits mailing list