[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

Gheorghe-Teodor Bercea via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 13 11:34:48 PDT 2019


gtbercea added a comment.

In D61765#1500233 <https://reviews.llvm.org/D61765#1500233>, @tra wrote:

> In D61765#1499957 <https://reviews.llvm.org/D61765#1499957>, @jdoerfert wrote:
>
> > Two small changes and then it is fine with me. @tra ?
>
>
> LGTM in general. I would still like to confirm that the changes work with libc++.


As soon as libc++ the limits header included in

  __clang_cuda_cmath.h:15
  ``` is not found:

__clang_cuda_cmath.h:15:10: fatal error: 'limits' file not found
#include <limits>

  Not even CUDA works actually so I'm not sure what the best answer to this problem is.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61765/new/

https://reviews.llvm.org/D61765





More information about the cfe-commits mailing list