[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat May 11 12:42:46 PDT 2019


lebedev.ri added a comment.

This will now trigger on https://godbolt.org/z/9oFMcB right?
Just want to point out that this will then have "false-positives" when that loop
is an OpenMP for loop, since range-for loop is not available until OpenMP 5.

I don't think this false-positive can be avoided though, if building without
`-fopenmp` there won't be anything about OpenMP in AST,
and thus no way to detect this case..


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61827/new/

https://reviews.llvm.org/D61827





More information about the cfe-commits mailing list