[PATCH] D61700: [clang-tidy] readability-redundant-declaration: fix false positive with C "extern inline"

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 10 09:30:40 PDT 2019


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM with some testing nits.



================
Comment at: clang-tools-extra/test/clang-tidy/readability-redundant-declaration.c:32
+extern inline void g();
\ No newline at end of file

----------------
Please add a newline.


================
Comment at: clang-tools-extra/test/clang-tidy/readability-redundant-declaration.cpp:81
+// CHECK-FIXES: {{^}}// extern g{{$}}
\ No newline at end of file

----------------
Please add a newline.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61700/new/

https://reviews.llvm.org/D61700





More information about the cfe-commits mailing list