[PATCH] D61509: [PragmaHandler] Expose `#pragma` location

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 7 09:17:57 PDT 2019


lebedev.ri added a comment.

In D61509#1493714 <https://reviews.llvm.org/D61509#1493714>, @jdenny wrote:

> In D61509#1493703 <https://reviews.llvm.org/D61509#1493703>, @lebedev.ri wrote:
>
> > It would have been better to submit this refactor as a new patch..
>
>
> Sorry, I didn't realize that was the norm.  I can do that now if it would help.  I can also revert changes to this patch if the goal is to make it easier to reference the old version.


I think that would be good. This current diff would be a simple NFC cleanup, i think i will signoff it even.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61509/new/

https://reviews.llvm.org/D61509





More information about the cfe-commits mailing list