[PATCH] D61497: [clangd] Introduce a structured hover response

[Sam McCall via Phabricator via cfe-commits]

sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/XRefs.h:53
+struct HoverInfo {
+  using Type = std::string;
+  struct Param {
----------------
ilya-biryukov wrote:
> NIT: maybe go with `std::string Type` at a use-site instead?
> The scope of the name is large enough to make single-letter names a bit confusing
We had discussed making Type a struct, in case we want to add links etc to it later in a back-compatible way.

The typedef doesn't achieve that, I agree with just inlining std::string if we're not going to have the struct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61497/new/

https://reviews.llvm.org/D61497