[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

Fri May 3 08:01:05 PDT 2019

ABataev added a comment.

In D61509#1489761 <https://reviews.llvm.org/D61509#1489761>, @jdenny wrote:

> In D61509#1489752 <https://reviews.llvm.org/D61509#1489752>, @ABataev wrote:
>
> > If the patch is going to be accepted, then definitely it must be solution #1.
>
>
> I certainly have no objection to that and will be happy to implement it, but can you help me to understand the rationale?  (Thanks for your quick response!)

Another one annotation token may significantly change the parsing process. It will require a lot of rework in the parsing of OpenMP pragmas plus may lead to some unpredictable results like endless parsing in some cases etc. It is much easier to change the tests rather than modify the whole parsing procedure.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61509/new/

https://reviews.llvm.org/D61509