[PATCH] D60605: [clangd] Revamp textDocument/onTypeFormatting.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 2 09:13:53 PDT 2019


ilya-biryukov added a comment.

In D60605#1485375 <https://reviews.llvm.org/D60605#1485375>, @sammccall wrote:

> I'm not able to reproduce this, can you give a complete example?


After adding a newline here:

  int test(bool x) {
    if (x)
      return 10; // All spelled tokens are accounted for.
                 // that takes two lines^
  }

I get:

  int test(bool x) {
    if (x)
      return 10; // All spelled tokens are accounted for.
    // that takes two lines
    ^
  }

Maybe that's due to some extra logic applied in VSCode on top of what we do.
Let me know if this does not reproduce.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60605/new/

https://reviews.llvm.org/D60605





More information about the cfe-commits mailing list