[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP
Paul Robinson via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Apr 26 11:49:12 PDT 2019
probinson added a comment.
In D60283#1480546 <https://reviews.llvm.org/D60283#1480546>, @aganea wrote:
> Thanks Paul, your solution is even better. I'll apply rL333311 <https://reviews.llvm.org/rL333311> locally - if everything's fine, do you mind if I re-land it again?
I suggest you do *not* use my patch unmodified, because it stops generating any checksums as soon as it finds one preprocessed file. The functionality in your patch seems better, to skip checksums only for those files that look like they were preprocessed. If you want to take my patch and remove the extra flag from CGDebugInfo that "remembers" that we've previously seen a file with line directives, that would be fine.
CHANGES SINCE LAST ACTION
More information about the cfe-commits