[PATCH] D42642: [CUDA] Detect installation in PATH

Fri Apr 26 06:53:38 PDT 2019

Hahnfeld marked an inline comment as done.
Hahnfeld added a comment.
Herald added a subscriber: ormris.

In D42642#1479013 <https://reviews.llvm.org/D42642#1479013>, @aganea wrote:

> Just a quick heads-up - the `cuda-detect-path.cu` test fails on WSL/Ubuntu 18.04:

Hmm, maybe that's because of symlinks. By chance, can you debug print the values of `real_path` and `parent_path`? They are supposed to resolve the links which is required for the candidate search to work and the test to pass.

================
Comment at: cfe/trunk/lib/Driver/ToolChains/Cuda.cpp:98-101
+        SmallString<256> ptxasAbsolutePath;
+        llvm::sys::fs::real_path(*ptxas, ptxasAbsolutePath);
+
+        StringRef ptxasDir = llvm::sys::path::parent_path(ptxasAbsolutePath);
----------------
These calls.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D42642/new/

https://reviews.llvm.org/D42642