[PATCH] D61134: [Analyzer] Iterator Checkers - Do an early return after handling calls

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 25 13:46:29 PDT 2019


NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

Thx, this is safer!



================
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:566
       const auto *InstCall = dyn_cast<CXXInstanceCall>(&Call);
       if (Func->getParamDecl(0)->getType()->isRValueReferenceType()) {
         handleAssign(C, InstCall->getCXXThisVal(), Call.getOriginExpr(),
----------------
`CXXMethodDecl` has a lot of fancy getters on it, such as `isMoveAssignmentOperator()`.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61134/new/

https://reviews.llvm.org/D61134





More information about the cfe-commits mailing list