[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns
Richard Townsend (Arm) via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 25 08:18:19 PDT 2019
richard.townsend.arm added inline comments.
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1074
+ if (!RD->hasTrivialCopyAssignment())
+ return true;
+ return false;
> Should this function also check for user-provided constructors?
I think it should: I speculatively added these two lines
and it resolved the problem with `std::setw` I mentioned in the bug tracker (which means Electron could start).
CHANGES SINCE LAST ACTION
More information about the cfe-commits