[PATCH] D61122: [clangd] Don't build clangd or run its tests when LLVM_ENABLE_THREADS is off, unless specifically directed to do so

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 25 03:21:48 PDT 2019

ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

A better name could definitely be nice, e.g. `BUILD_CLANGD` would've been much nicer.
But the current one is also okayish, being consistent with existing names is a good reason to keep it that way.

Comment at: CMakeLists.txt:13
+# FIXME: move clangd to its own self-contained subtree and clean this up.
+option(CLANGD_BUILD "Build clangd" ${LLVM_ENABLE_THREADS})
NIT: maybe comment why we disable clangd with no threads?
Merely mentioning this configuration is not supported in clangd would be good enough.

Maybe it's just me, but I tend to find following cmake scripts really hard and even obvious comments make it much simpler.

  rCTE Clang Tools Extra



More information about the cfe-commits mailing list