[PATCH] D61118: [MinGW] Fix dllexport of explicit template instantiation
Shoaib Meenai via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 25 00:45:41 PDT 2019
smeenai added a comment.
LGTM, though I'd wait for Hans and/or Reid too.
I like the GCC/MinGW behavior here much more than the MSVC behavior. Having to mark the definitions only in the explicit instantiations case (for MSVC) whereas everything else requires you to mark the declarations is a weird inconsistency.
CHANGES SINCE LAST ACTION
More information about the cfe-commits