[PATCH] D60995: [clang][HeaderSearch] Make sure there are no backslashes in suggestedPath
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Apr 24 00:42:43 PDT 2019
sammccall added inline comments.
Comment at: clang/include/clang/Lex/HeaderSearch.h:710
+ /// Suggest a path by which the specified file could be found, for use in
+ /// diagnostics to suggest a #include. Returned path will be valid for
+ /// include-directive.
I don't think this is specific enough - on windows, backslashes are valid (or at least accepted by clang).
I'd suggest specifically mentioning forward slashes.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits