[PATCH] D60912: MS ABI: handle inline static data member and inline variable as template static data member
Jennifer Yu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 23 15:53:14 PDT 2019
jyu2 updated this revision to Diff 196346.
jyu2 retitled this revision from "MS ABI: handle inline static data member as template static data member" to "MS ABI: handle inline static data member and inline variable as template static data member".
jyu2 edited the summary of this revision.
jyu2 added a comment.
Thanks for your review and catch what I were missing for inline variable part(only inline static data member were fix in previous patch).
As you suggested, instead using GVA_DiscardableODR to put inline variable's initialization function or inline static member's initialization functions into to COMDAT group with global being initialized.
The GVA_DiscardableODR is for weak linkage of inline variables.
Let me know if you see problems.
Thank you so much!
CHANGES SINCE LAST ACTION
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 4906 bytes
Desc: not available
More information about the cfe-commits