[PATCH] D60967: Move setTargetAttributes after setGVProperties in SetFunctionAttributes

Scott Linder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 23 14:38:40 PDT 2019

scott.linder added a comment.

In D60967#1476226 <https://reviews.llvm.org/D60967#1476226>, @rjmccall wrote:

> I suspect that other OpenCL and CUDA implementations don't care at all about symbol visibility for device-side code generation, and giving kernel functions default visibility seems like the right thing to do for the (relatively few) things at the AST level that are sensitive to that, like template visibility.  Would you mind reaching out to other implementors about that?
> This patch seems fine to me regardless.

Yes, I can certainly identify who would be interested in terms of OpenCL and Cuda and work on moving this up to the AST.

If you don't object to this patch then is it reasonable for me to submit it? It will get us the required behavior for AMDGPU while I work on the more general solution.

  rC Clang



More information about the cfe-commits mailing list