[PATCH] D60967: Move setTargetAttributes after setGVProperties in SetFunctionAttributes
Scott Linder via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 23 12:47:21 PDT 2019
scott.linder added a comment.
In D60967#1476029 <https://reviews.llvm.org/D60967#1476029>, @rjmccall wrote:
> Shouldn't it be an error if the user tries to give it hidden visibility?
We effectively consider the user explicitly specifying that a symbol is e.g. a `kernel` to also carry with it visibility information. We don't want to require the user to redundantly specify that a kernel is not hidden, when it is never meaningful for it to be hidden.
CHANGES SINCE LAST ACTION
More information about the cfe-commits