[PATCH] D60883: [OpenMP] Avoid emitting maps for target link variables when unified memory is used

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 18 12:42:07 PDT 2019


ABataev added inline comments.


================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:7956
+    // If using unified memory, no need to do the mappings.
+    if (CGF.CGM.getOpenMPRuntime().hasUnifiedAddressingSupport())
+      return;
----------------
Hmm, what about regular declare target declarations? Also, this is not enough. You also should not capture such variables in the captured regions.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60883/new/

https://reviews.llvm.org/D60883





More information about the cfe-commits mailing list