[PATCH] D55044: [clang-tidy] check for Abseil make_unique

Andy Zhang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 18 11:25:21 PDT 2019

axzhang marked 3 inline comments as done.
axzhang added inline comments.

Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:69
+      IgnoreMacros(Options.getLocalOrGlobal("IgnoreMacros", true)),
+      IgnoreListInit(Options.get("IgnoreListInit", false)) {}
hintonda wrote:
> hintonda wrote:
> > axzhang wrote:
> > > hintonda wrote:
> > > > You’re setting it false here.
> > > I thought that false was the default value if the options do not contain "IgnoreListInit"?
> > Do you have a test that passes this option?  I didn’t see one.
> I could be wrong, but when you do an Options.get(), that looks at what was passed on the commandline, and if it wasn't found, it sets the default provided.
Fixed by changing the Options value to "1" instead of true in the AbseilTidyModule



More information about the cfe-commits mailing list