[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 18 09:51:00 PDT 2019


ABataev added inline comments.


================
Comment at: lib/Sema/SemaOpenMP.cpp:4207
+        DSAStack->hasRequiresDeclWithClause<OMPDynamicAllocatorsClause>()) &&
+      !CurContext->isDependentContext()) {
+    // Register target to DSA Stack.
----------------
ABataev wrote:
> Better to check for the dependent context at first, only after that check for the clause
Better to check for the dependent context at first, only after that check for the clause


================
Comment at: test/OpenMP/requires_target_messages.cpp:5
+  int a;
+  #pragma omp target // expected-note {{Target previously encountered here}} expected-note {{Target previously encountered here}} expected-note {{Target previously encountered here}} expected-note {{Target previously encountered here}}
+  {
----------------
Just `expected-note 4 {{`


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60875/new/

https://reviews.llvm.org/D60875





More information about the cfe-commits mailing list