[PATCH] D55044: [clang-tidy] check for Abseil make_unique

Don Hinton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 17 20:52:29 PDT 2019


hintonda added inline comments.


================
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:69
+      IgnoreMacros(Options.getLocalOrGlobal("IgnoreMacros", true)),
+      IgnoreListInit(Options.get("IgnoreListInit", false)) {}
 
----------------
axzhang wrote:
> hintonda wrote:
> > You’re setting it false here.
> I thought that false was the default value if the options do not contain "IgnoreListInit"?
Do you have a test that passes this option?  I didn’t see one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55044/new/

https://reviews.llvm.org/D55044





More information about the cfe-commits mailing list