[PATCH] D60516: [LTO] Add plumbing to save stats during LTO on Darwin.

Teresa Johnson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 17 10:23:19 PDT 2019


tejohnson added a comment.

LGTM with a minor fix needed below.

Darwin still uses the old LTO API, which is why the lto Config based handling in the new LTO API (LTO.h/LTO.cpp) are not being used on this path.



================
Comment at: llvm/lib/LTO/LTOCodeGenerator.cpp:101
+    "lto-stats-file",
+    cl::desc("With PGO, include profile count in optimization remarks"),
+    cl::Hidden);
----------------
Wrong description for this option


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60516/new/

https://reviews.llvm.org/D60516





More information about the cfe-commits mailing list