[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

Don Hinton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 17 08:31:16 PDT 2019

hintonda marked 2 inline comments as done.
hintonda added inline comments.

Comment at: clang-tools-extra/clang-tidy/add_new_check.py:381
+  # Don't allow 'clang' or 'llvm' namespaces
+  if module == 'llvm' or module == 'clang':
+    namespace = module + '_check'
alexfh wrote:
> We don't have the `clang` module. No need to check for it here. If we ever add one (which I doubt), we can modify this script again. But for now let's remove this to avoid confusion.
No problem.  Or we could outlaw it...

Comment at: clang-tools-extra/clang-tidy/rename_check.py:268
+  if old_module != new_module or new_module == 'llvm' or new_module == 'clang':
+    if new_module == 'llvm' or new_module -- 'clang':
+      new_namespace = new_module + '_check'
alexfh wrote:
> `--`?
> Anyways, we don't have (or plan to have) a module named `clang`.
Thanks for catching that...

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list