[PATCH] D60778: Make precompiled headers reproducible by switching OpenCL extension to std::map

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 17 06:42:27 PDT 2019

lebedev.ri added a comment.

In D60778#1470181 <https://reviews.llvm.org/D60778#1470181>, @riccibruno wrote:

> Mmm. I hope I am not missing something obvious, but how is this actually fixing the issue ? I don't see why the order between the `Type *` and between the `Decl *` should be deterministic (I think they will be when they are part of the same slab in the allocator, but I don't see why the slab ordering should be stable).

Oh. Duh.
Can a custom comparator be provided for these `std::map`, equivalent to the one in https://reviews.llvm.org/D60379 ?
Something like `getTypeID(LHS.first->getCanonicalTypeInternal()) < getTypeID(RHS.first->getCanonicalTypeInternal())` ?



More information about the cfe-commits mailing list