[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 🔍

Stephane Moore via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 16 20:32:37 PDT 2019


stephanemoore added a comment.

In D59806#1469257 <https://reviews.llvm.org/D59806#1469257>, @aaron.ballman wrote:

> LGTM! You can either land this now and refactor after the AST matcher lands, or you can wait until the AST matcher lands and land this patch after -- your call.


I will plan on landing this and then follow up after the new AST matcher lands. I want to make sure the design for the new AST matcher is solid and evaluate the implications of the different approaches. I plan on updating both `ForbiddenSubclassingCheck` <https://github.com/llvm/llvm-project/blob/2946cd7/clang-tools-extra/clang-tidy/objc/ForbiddenSubclassingCheck.cpp#L55> and `SuperSelfCheck` once the new AST matcher lands 👍


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59806/new/

https://reviews.llvm.org/D59806





More information about the cfe-commits mailing list