[PATCH] D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests.

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 16 18:01:05 PDT 2019

NoQ added a comment.

In D60732#1469026 <https://reviews.llvm.org/D60732#1469026>, @jdenny wrote:

> The original patch added documentation to `-cc1 -help`.  Doxygen for VerifyDiagnosticConsumer is another possibility except it currently doesn't mention command-line usage at all.  Maybe it should?

I would have definitely discovered this feature earlier if it was mentioned on the doxygen page for VerifyDiagnosticConsumer!

In D60732#1467504 <https://reviews.llvm.org/D60732#1467504>, @Charusso wrote:

> I think this functionality is unused because you would split the file into six to reduce the overhead/scroll and that is it.

The current test tests all 6 modes on all functions, that's a lot of coverage. You can't obtain the same coverage by splitting the file into mode-specific tests; you'd have to duplicate all code in all files, is much harder to maintain than `#ifdef`s. It would probably still be easier to read, but the constant fear that the files aren't actually identical pretty much defeats the purpose.

  rC Clang



More information about the cfe-commits mailing list