[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types
Roman Lebedev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 16 13:46:48 PDT 2019
lebedev.ri added a comment.
In D59712#1469295 <https://reviews.llvm.org/D59712#1469295>, @craig.topper wrote:
> Wondering if it would be better to assert for asking for the sign of an unsigned APSInt. I could see a caller just wanting to get the msb for some reason and not knowing that isNegative won’t work.
Yes, i, too, would think an assert is much better solution (since i literally just tripped over this in this review.)
CHANGES SINCE LAST ACTION
More information about the cfe-commits