[PATCH] D60539: Add -std=c++14 language standard option to tests that require C++14 default

Nemanja Ivanovic via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 16 11:30:17 PDT 2019

nemanjai added a comment.

> Do you need to build clangd? We explicitly don't aim to support building everywhere clang can be built, maybe we should just disable in this case?

Our environment includes various OS levels running on PowerPC. We certainly wouldn't want to disable building/testing `clangd` on all our PowerPC machines. Is there a way to disable it only on certain OS levels?

Furthermore, it seems a little too intrusive to disable an otherwise functional component simply because some test cases rely on a specific language standard default.

Would it be an acceptable solution to add another `StringRef` parameter to `ShouldCollectSymbolTest::build()` - let's call it `ExtraArgs`, to which we can add options such as `-std=c++14` if the test being built relies on that option?



More information about the cfe-commits mailing list