[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Mariya Podchishchaeva via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 16 06:24:50 PDT 2019


Fznamznon added inline comments.


================
Comment at: clang/test/SemaSYCL/device-attributes-on-non-sycl.cpp:2
+// RUN: %clang_cc1 -fsyntax-only -fsycl-is-device -verify %s
+// Now pretend that we're compiling a C++ file. There should be warnings.
+// RUN: %clang_cc1 -fsyntax-only -verify -x c++ %s
----------------
aaron.ballman wrote:
> This comment confuses me -- the file *is* a C++ file and the preceding RUN line treats it as such, doesn't it?
I've tried to say that we compile regular C++ file without SYCL mode enabled. Looks like it can confuse since files with SYCL code have cpp extension... I will rewrite this comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60455/new/

https://reviews.llvm.org/D60455





More information about the cfe-commits mailing list