[PATCH] D58236: Make address space conversions a bit stricter.

Bevin Hansson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 16 04:10:34 PDT 2019

ebevhan added a comment.

In D58236#1467151 <https://reviews.llvm.org/D58236#1467151>, @Anastasia wrote:

> In D58236#1466263 <https://reviews.llvm.org/D58236#1466263>, @ebevhan wrote:
> > Well, it doesn't seem to me like there is consensus on prohibiting nested address space conversion like this.
> >
> > I can simply redo the patch to only include the bugfix on implicit conversions and drop the nesting level checks.
> I thought the conclusion is:
> - Explicit conversions allowed for nested pointers with a warning.
> - Implicit conversions are disallowed for nested pointers with an error.
>   Do you not see it this way?

Alright, that seems reasonable to me. Some of the patch goes away, then. I'll update it.



More information about the cfe-commits mailing list