[PATCH] D59640: [clangd] Add TemplateArgumentList into Symbol

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added inline comments.


================
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:566
+        printTemplateSpecializationArgs(ND);
+    S.TemplateSpecializationArgs = TemplateSpecializationArgs;
     if (Opts.StoreAllDocumentation)
----------------
kadircet wrote:
> ilya-biryukov wrote:
> > Any reason to not always fill in this field?
> > 
> It is simply because `printTemplateSpecializationArgs` should return an empty string in other cases. Since we mark all explicit specializations as *not* indexed for code completion.
NIT: That's is not obvious. Could we fill it right after `Name` and `Scope`?
These 3 fields are related, therefore feels natural to have code filling them together. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59640/new/

https://reviews.llvm.org/D59640