[PATCH] D60572: creduce-clang-crash: Use `!` instead of `not`

Amy Huang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 11 11:59:51 PDT 2019


akhuang added a comment.

Looks good- if we remove `not` there are a few other things that should be removed



================
Comment at: clang/utils/creduce-clang-crash.py:138
         if "fatal error:" in msg_re:
           self.is_crash = False
         break
----------------
also wouldn't need `self.is_crash`


================
Comment at: clang/utils/creduce-clang-crash.py:178
 
     crash_flag = "--crash" if self.is_crash else ""
 
----------------
We should remove `crash_flag` as well


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60572/new/

https://reviews.llvm.org/D60572





More information about the cfe-commits mailing list