[PATCH] D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup

Bruno Ricci via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 11 11:02:21 PDT 2019


riccibruno created this revision.
riccibruno added reviewers: rjmccall, Quuxplusone.
riccibruno added a project: clang.
Herald added a subscriber: cfe-commits.

The goal here is to exercise each rule in [basic.lookup.argdep] at least once. These new tests expose what I believe are 2 issues:

1. CWG 1691 needs to be implemented (`p2:  [...] Its associated namespaces are the innermost enclosing namespaces of its associated classes [...]`) The corresponding tests are `adl_class_type::X2` and `adl_class_type::X5`.

2. The end of paragraph 2 (`[...] Additionally, if the aforementioned set of overloaded functions is named with a template-id, its associated classes and namespaces also include those of its type template-arguments and its template template-arguments.`) is not implemented. Closely related, the restriction on non-dependent parameter types in this same paragraph needs to be removed. The corresponding tests are in `adl_overload_set`. (both issues are from CWG 997).


Repository:
  rC Clang

https://reviews.llvm.org/D60570

Files:
  test/CXX/basic/basic.lookup/basic.lookup.argdep/p2-associated-namespaces-classes.cpp
  test/CXX/basic/basic.lookup/basic.lookup.argdep/p3.cpp
  test/CXX/basic/basic.lookup/basic.lookup.argdep/p4.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60570.194718.patch
Type: text/x-patch
Size: 13197 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190411/84774109/attachment-0001.bin>


More information about the cfe-commits mailing list