[PATCH] D59639: [clangd] Print template arguments helper

[Eric Liu via Phabricator via cfe-commits]

ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: clang-tools-extra/clangd/AST.cpp:139
+      // location information.
+      printTemplateArgumentList(OS, Cls->getTemplateArgs().asArray(), Policy);
+    }
----------------
Could you also add a test case for this with the current behavior and a FIXME?


================
Comment at: clang-tools-extra/unittests/clangd/PrintASTTests.cpp:47
+    }
+    std::vector<std::string> TemplateArgs;
+    const std::vector<Position> Points;
----------------
maybe `s/TemplateArgs/TemplateArgsAtPoints/` for clarity


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59639/new/

https://reviews.llvm.org/D59639