[PATCH] D60500: [clangd] Refactor speculateCompletionFilter and also extract scope.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 10 01:45:53 PDT 2019


sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.

Intent is to use the heuristically-parsed scope in cases where we get bogus
results from sema, such as in complex macro expansions.
Added a motivating testcase we currently get wrong.

Name changed because we (already) use this for things other than speculation.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D60500

Files:
  clangd/CodeComplete.cpp
  clangd/CodeComplete.h
  unittests/clangd/CodeCompleteTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60500.194461.patch
Type: text/x-patch
Size: 7070 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190410/0e981006/attachment.bin>


More information about the cfe-commits mailing list