[PATCH] D52527: [clang-format] fix Bug 38686: add AfterCaseLabel to BraceWrapping

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 8 03:53:19 PDT 2019


MyDeveloperDay added a subscriber: reuk.
MyDeveloperDay added a comment.

@ownenpan might be worth checking with @reuk who has been adding some options for the JUCE style guide and looking at the JUCE code it seems this style might match their style.



================
Comment at: include/clang/Format/Format.h:638
+    /// \endcode
+    bool AfterCaseLabel;
     /// Wrap class definitions.
----------------
krasimir wrote:
> This comment seems outdated (the one in `ClangFormatStyleOptions.rst` seems more recent).
> 
> The `ClangFormatStyleOptions.rst` file is automatically generated from this file. Please update this comment and regenerate `ClangFormatStyleOptions.rst` by using the `clang/docs/tools/dump_format_style.py` script.
@krasimir do you happen to know if this script is run by the build or is supposed to be run by the developer after making the change to Format.h

If the latter, then I reckon the two are out of sync, perhaps I should submit a change to realign them, but really there should be some sort of make target that lets us determine when they diverge otherwise they'll keep changing


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52527/new/

https://reviews.llvm.org/D52527





More information about the cfe-commits mailing list