[PATCH] D60151: [clang-tidy] Rename llvm checkers to llvm-project

Don Hinton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 4 06:34:01 PDT 2019


hintonda added a comment.

In D60151#1454741 <https://reviews.llvm.org/D60151#1454741>, @alexfh wrote:

> In D60151#1454105 <https://reviews.llvm.org/D60151#1454105>, @hintonda wrote:
>
> > - Rename llvm directory to llvm_project.
> > - Change llvm- to llvm-project-.
> > - Rename files.
>
>
> Awesome! Thanks for doing this. Could you ensure that the add_new_check.py script still works?


Thanks for mentioning this.  Found a missing rename discovered by add_new_check.py which I'll checkin shortly.  However, I'm not sure how best to solve a rename issue.

In rename_check.py, module names can't be hyphenated, e.g.:

  190:  old_module = args.old_check_name.split('-')[0]
  191:  new_module = args.new_check_name.split('-')[0]

If we keep this pattern, then "llvm-project" won't work.  It would need to be something like "llvmproject" or something else.  Please let me know your preference.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60151/new/

https://reviews.llvm.org/D60151





More information about the cfe-commits mailing list